Skip to content

Conversation

@nickolay168
Copy link

@nickolay168 nickolay168 commented Dec 20, 2025

Clazy changes

In the restylers configuration , staring from v0.597.0 (2025-09-19) the new linter clazy was introduced. It relies on the pre built docker image, which is missing some dependencies, including PkgConfig.
In this PR I have disabled the linter for now, however, the longer term solution would be to use docker image, which supports building qTox.

Currently CI/CD will always fail with the error

CMake Error at /usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
Call Stack (most recent call first):
  /usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.31/Modules/FindPkgConfig.cmake:114 (find_package_handle_standard_args)
  cmake/Dependencies.cmake:12 (find_package)
  CMakeLists.txt:194 (include)

This change is Reviewable

Changes to mypy

There were some insignificant changes related to minidom typing, which used to break the CI/CD. I have added two type fixes to pass.

Changes for python linters

The new version of restyled also introduces several python linters i.e. autopep8, black, etc.
Most of changes in the tools/translate.py are caused by black.
I had to disable several python linters in restyled as without additional parameters they conflict with each other. For example black will reformat file, which will always be reformatted with yapf.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

Tip

Preview URL:

@github-actions github-actions bot added the bug Bug fix for the user, not a fix to a build script label Dec 20, 2025
@nickolay168 nickolay168 marked this pull request as draft December 20, 2025 08:58
@Green-Sky Green-Sky added this to the v0.8.3 milestone Dec 20, 2025
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 3e1abe7 to 3d339e2 Compare December 21, 2025 03:36
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 3d339e2 to aeadf90 Compare December 21, 2025 03:46
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from aeadf90 to 1f4d2f6 Compare December 21, 2025 04:02
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 1f4d2f6 to 5158d68 Compare December 21, 2025 04:22
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 5158d68 to 13a01bf Compare December 21, 2025 04:36
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 13a01bf to ba245d6 Compare December 21, 2025 04:38
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from ba245d6 to ae7e761 Compare December 21, 2025 04:51
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from ae7e761 to e3a4533 Compare December 21, 2025 04:54
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from e3a4533 to 17a5080 Compare December 21, 2025 05:10
@nickolay168 nickolay168 force-pushed the nickolay168/disable_clazy branch from 17a5080 to 1dacf2d Compare December 21, 2025 05:13
@nickolay168 nickolay168 marked this pull request as ready for review December 21, 2025 05:18
@nickolay168
Copy link
Author

@iphydf I have also fixed the CI/CD related to python, could you please review/merge the PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix for the user, not a fix to a build script

Development

Successfully merging this pull request may close these issues.

3 participants