-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Disable clazy check as it is missing cmake dependencies. #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickolay168
wants to merge
1
commit into
TokTok:master
Choose a base branch
from
nickolay168:nickolay168/disable_clazy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tip Preview URL: |
iphydf
approved these changes
Dec 20, 2025
3e1abe7 to
3d339e2
Compare
3d339e2 to
aeadf90
Compare
aeadf90 to
1f4d2f6
Compare
1f4d2f6 to
5158d68
Compare
5158d68 to
13a01bf
Compare
13a01bf to
ba245d6
Compare
ba245d6 to
ae7e761
Compare
ae7e761 to
e3a4533
Compare
e3a4533 to
17a5080
Compare
17a5080 to
1dacf2d
Compare
Author
|
@iphydf I have also fixed the CI/CD related to python, could you please review/merge the PR again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clazy changes
In the restylers configuration , staring from v0.597.0 (2025-09-19) the new linter clazy was introduced. It relies on the pre built docker image, which is missing some dependencies, including
PkgConfig.In this PR I have disabled the linter for now, however, the longer term solution would be to use docker image, which supports building qTox.
Currently CI/CD will always fail with the error
This change is
Changes to
mypyThere were some insignificant changes related to
minidomtyping, which used to break the CI/CD. I have added two type fixes to pass.Changes for python linters
The new version of restyled also introduces several python linters i.e.
autopep8,black, etc.Most of changes in the
tools/translate.pyare caused byblack.I had to disable several python linters in restyled as without additional parameters they conflict with each other. For example
blackwill reformat file, which will always be reformatted withyapf.