Repository navigation
feat(rust): harden acquisition reports and add source corrections - #596
LIghtJUNction wants to merge 5 commits into
Conversation
f5208c6 to
e72328a
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
e72328a to
02a21a7
Compare
cb8ef7e to
c2e242d
Compare
Make self-report writes atomic and add the Rust acquisition correction read/write contract with optimistic concurrency, consent and role safeguards, retention filtering, and PostgreSQL integration coverage.
c2e242d to
134105e
Compare
|
发现一个 365 天保留期边界上的功能问题(按当前 head
建议接着覆盖“读取过期 head → 按返回值提交新修正 → 成功,再提交旧版本仍应 409”的回归,并让保留期过滤与并发版本协议一致;修复时仍需保持旧 source/reason 不再展示、历史审计及并发写入边界。Go 对照实现也有相同读写条件,单纯保持 Go/Rust 一致并不能排除这一交互问题。 |
Keep acquisition correction read retention and optimistic write revisions consistent, preserve append-only expired audit rows, and cover the 100-row history boundary.
|
已修复上述 365 天边界回归(head 实现保持旧审计行 append-only,但在 新增回归覆盖:
当前 PR 已合入最新 main 并恢复 mergeable。格式、Clippy、RustSec、路由/行为对齐等已通过;完整 PostgreSQL 门禁被 base main 本身现有的 |
Exercise administrator role and permission gates, request validation, target-role boundaries, status mapping, optimistic conflict responses, and successful PostgreSQL-backed correction reads and writes.
|
今日继续补强 Rust acquisition 覆盖(head
完整 workspace 与 PostgreSQL aggregate job 仍在 acquisition 之前被 base main 的两个 |
Summary
UPSERT ... RETURNING, rejecting invalid user IDs before storageGET/POST /api/admin/acquisition/users/:id/correctionswith Go-compatible details/write permissions and target-role boundariesVerification
ai_directory.rsbefore the acquisition PostgreSQL suite: PR run 34283ce27fe6has the same twoCurrencyUnavailablefailures: main run 3424Coverage note
The non-PostgreSQL instrumentation baseline that identified this area remains
acquisition.rs40.00%,data.rs3.17%, andstore.rs0.69%. Ignored database tests are not credited by that baseline; this PR adds six durable PostgreSQL correction/report tests plus an always-on HTTP contract test, including permission/status mapping, expired-head recovery, optimistic concurrency, and pagination branches. The static route gate remains at zero unclassified outside-baseline routes. A fresh numerical LLVM coverage result is not claimed while the base-branch workspace failure prevents a clean full run.Scope
Rust backend only. No Go backend, frontend, or database migration changes.