Repository navigation
fix: support DSH 0.2.1 alpha and refresh the shared Pi submodule - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The compatibility ranges, dependency alignment, packaging workflow, and documentation are consistent with the stated validation goals.
Review effort: Balanced
Findings: None
What changed in this PR
Updates provider compatibility for DSH 0.2.1 alpha while preserving the existing release baseline.
Changes:
- Expands DSH and Cordis prerelease compatibility ranges.
- Aligns CI dependencies to each tested host version.
- Refreshes package metadata, documentation, tarball discovery, and the Pi submodule.
| File | Description |
|---|---|
scripts/select-host.mjs |
Installs a consistent DSH service set for testing. |
README.md |
Documents expanded host compatibility. |
package.json |
Bumps the release and updates semver ranges. |
package-lock.json |
Synchronizes package metadata and ranges. |
.github/workflows/ci.yml |
Tests baseline, alpha, and latest hosts. |
vendor/pi-lmm-provider |
Advances the shared Pi integration commit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Packaged-install regression found and fixed
The first expanded matrix exposed a real failure: ordinary runtime dependency ranges installed alpha authorization/pi-ai services into stable DSH. DSH correctly disabled those incompatible services, leaving the auth route unavailable (404). Source-link tests did not reveal the issue because they reused the development dependency tree.
Authorization, home paths and the pi-ai adapter now use host-owned peerDependencies with exact stable devDependencies. No allow-version exemptions, disabled compatibility checks or skipped assertions are used. A new manifest regression test prevents host-owned services from returning to independently installed runtime dependencies. Native failures now include redacted diagnostics.
Validation
The final dependency fix passed typecheck, all 14 unit tests, package checks, actual Web-host OAuth/RPC/catalog/streaming/sign-out tests, and the built tarball on BOTH stable 0.2.0-rc.2 and alpha 0.2.1-alpha.1 under Node 24:
https://github.com/TokenNotIncluded/dsh-lmm-provider/actions/runs/37469603779
The permanent Node 22.19 matrix rechecks stable/alpha/latest on the final commit. All temporary writer workflows have been removed.
Production OAuth, billable inference, Desktop GUI acceptance and package publication were not performed. Existing release asset URLs remain unchanged rather than referencing an unpublished alpha.6 release.