Repository navigation
fix(ci): repair RPC audits and Core process test prerequisites - #916
Conversation
|
Automatic CI finished: run 38656514072 / protocol, candidate head Important limitation: native RPC stopped at Other failures remain: missing Go contract/race, Store PostgreSQL, durable event recovery and service boundary steps passed. File-only fixture contracts, formatting and other earlier-dependent steps were skipped after the docs failure. Local scoped evidence remains 12 passed plus one existing Docker-dependent skip, not full acceptance. No manual run, rerun, merge or deployment was performed. |
|
Added narrowly scoped fixture repair in New AST regression failed against the previous fixture (11 versus 12) and passes after this one-literal update. Final local suite: 13 passed, 1 existing Docker Compose skip. Three additional mutations (missing component, unexpected extra component, weakening equality to a subset check) all fail the new regression. Python compilation and whitespace checks passed. Remote source blobs match tested local bytes. Only the same two fixture files changed; reviewed catalog hashes, application schema and grants remain untouched. Live PostgreSQL validation of the OID audit is still pending the automatic run for this exact new head. No manual dispatch or merge. |
|
Verified terminal automatic CI result for exact head Native protobuf round trips and failure recovery PASSED in real Docker/PostgreSQL. The fixture passed the exact 12-component assertion and mandatory runtime privilege audit (including no charging schema USAGE/CREATE and no request table/column writes), then completed all remaining scenarios. Log confirmations at 00:21:25–00:21:31 UTC include fresh installation/repeat-init refusal, native teams/protobuf/separate credentials, extension restart/replacement/wrong service token isolation, reconnect/bounded database failure/persistent keys/immediate revocation/closed model routes. This supplies the previously missing live validation for the scoped OID repair. Overall workflow remains FAILED: the unrelated missing documentation link and Rust schema-catalog/CLI/model-process failures persist. Go contract/race, Store PostgreSQL, durable event recovery and service boundaries passed. Earlier-dependent fixture-contract/format stages remained skipped after the docs failure; local fixture regressions are separately documented above. Keep Draft; this is scoped evidence, not complete #915 or project acceptance. No catalog hash/grant changes, manual CI dispatch, merge or deployment. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Continue #915 in existing PR #916. Merge WIP 906f638 without rewriting history or changing its application code and reviewed schema fingerprints. Use the same digest-pinned PostgreSQL 18 image as the RPC fixture. Compile test artifacts before binding the actual Core executable, SHA-256 and private short process root; keep all Rust tests and failure propagation. Replace the missing opening-import guide link with its pending A03 PR. Preserve the prior RPC privilege-denial and component-inventory repairs. Two new topology regressions fail before the patch; five affected topology tests pass after it. Five shell-plumbing cases pass, including compile and test failures; this is not real Cargo/database acceptance. Offline RPC fixture: 13 passed, one existing Docker skip. YAML, JavaScript and shell syntax, changed document links and diff whitespace were checked. Rust/PostgreSQL/Docker are unavailable locally; full integration CI and independent acceptance remain pending.
2b0ba15
into
wip/rust-core-go-extensions
Scope
Continue #915 in this existing PR. Latest commit:
80523172c057fb26997cbdb0cf764f319d867c7b.Synchronize with WIP
906f6382ad19f213cb3aefe41915c3ab993ab7a1without rewriting history. Preserve all current application, OAuth, abuse-control and schema changes. This PR changes only five fixture/workflow/documentation files relative to that WIP revision.Repairs
deployment/docker/compose.identity.yml, instead of testing canonical catalogs on PostgreSQL 17. PostgreSQL 18 includes table NOT NULL constraints inpg_constraint; PostgreSQL 17 does not. The repository catalog query includes this table, so cross-major fingerprints are not interchangeable. No reviewed fingerprint or application schema is changed by this repair.cargo test --locked --all-targets --no-fail-fastcommand. All six model process cases remain enabled. No skip, ignored failure or success-only application mock is added.PostgreSQL catalog references: https://www.postgresql.org/docs/18/catalog-pg-constraint.html and https://www.postgresql.org/docs/17/catalog-pg-constraint.html.
Actual verification
node --test --test-name-pattern='Core CI|manual checks reuse|independent check failures|CLI consumers' scripts/workflow-topology.test.mjs: 5 passed after the fix.tee; it is not Core/database acceptance.python3 -B scripts/test_core_rpc_fixture.py -v: 13 passed, 1 existing Docker-dependent skip.bash -n,node --check, diff whitespace and the changed document-link delta passed.Historical real integration evidence: run https://github.com/TokenNotIncluded/lmm-api/actions/runs/38658171431 tested PR head
b97360a5through merge sourcea9eeabff. Its native protobuf/RPC recovery step passed. The overall run failed in document links, catalog/CLI tests and missing model-process environment. This supersedes the original description's claim that native RPC had never been tested, but it does not verify this new integrated commit.Remaining acceptance
The catalog mismatch explanation is source-supported; the latest canonical fingerprints and all six process cases still require a real run on this new commit. WIP advanced during this work and its newer reviewed fingerprints were preserved, not replaced with older observed values.
Local Rust, PostgreSQL, Docker and agcc are unavailable. The local source came from a hash-checked partial CI source archive, with affected current files verified against GitHub. The full documentation/topology/application checks were not run locally; targeted self-tests are not independent acceptance. No dependencies were installed, no private process logs uploaded, and no production service, release or deployment changed.
Keep #915 open until the new integration checks and remaining failures are verified. No merge has been performed.