fix: Pi 直接调用官方安装脚本,不再用 npm 替代 - #4
Merged
Merged
Conversation
Keep upstream dependency, permission, PATH and cancellation handling intact. Run the LMM plugin follow-up only for its tested host, without downgrading Pi. Retain native Termux dependencies and add installer-delegation regressions.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正
Pi 官网 https://pi.dev/ 提供
install.sh/install.ps1。之前只用了 npm 示例,遗漏了官方安装器。pi.sh/pi.ps1现在完整获取官网脚本后原样执行,不复制或改写其 Node、权限、安装位置、PATH、Windows Git Bash 和交互处理。仍是平铺结构,没有恢复生成器、私有运行时或网络加速。两个入口分别 12 / 11 行,包含 Termux 原生依赖准备和 LMM 插件衔接。后续插件使用官方选定的安装路径和同一执行环境;取消、卸载或失败不继续安装插件。两个菜单已指向新入口提交
b7b066e5ca0e8a16b13c37a308419bc475cd459b。DSH 当前官网/README 使用 npx,旧
scripts/install.sh已不在当前树中,因此没有冒用归档脚本;其现有 npm/pnpm 安装不变。Codex / Claude 已直接使用官方安装脚本,不重写。验证
已验证 HEAD:
132f9cb57e79b1605f300180c98ba6d6a62eeb3bCI:https://github.com/TokenNotIncluded/lmm-scripts/actions/runs/35568153173
5 个任务全部通过:Ubuntu、macOS、Windows 的命令与真实 CLI 安装检查,以及 Debian 12 / Alpine 3.22 的 Codex、Claude 官方安装器检查。21 项 Python 测试、16 项 PowerShell 命令检查(含 Windows PowerShell 5.1)、ShellCheck 通过。覆盖官方失败/取消、安装路径不在 PATH、版本探测和插件错误、Termux 依赖准备、不执行部分下载内容。
实际 Pi 官方安装器装上的是 0.86.1。现有 LMM alpha 只验证过 0.85.1,自动插件安装会明确跳过;这次没有把插件适配到 0.86.1,也没有通过 npm 降级宿主。 官方安装器的真实调用已验证,不能把它说成最新 Pi + LMM 插件集成已验证。
Termux 仅模拟测试,未真机验证。没有执行账号登录、模型调用或桌面 GUI 测试。不部署网站,不修改上层子模块指针。