Repository navigation
fix: update Pi integration for 1.0.4 and retain legacy compatibility - #13
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused upgrade preserves legacy requirements, strengthens compatibility checks, and has no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the LMM provider’s development host to Pi 1.0.4 while retaining legacy compatibility.
Changes:
- Bumps the provider to
0.1.0-alpha.4and refreshes dependencies. - Expands CI coverage across legacy and current Pi hosts.
- Requires native-loader registration of
lmm-cache.
| File | Description |
|---|---|
| scripts/test-pi.mjs | Adds the lmm-cache registration check. |
| README.md | Lists Pi 1.0.4 among tested hosts. |
| package.json | Updates provider and development host versions. |
| package-lock.json | Refreshes the Pi 1.0.4 dependency tree. |
| .github/workflows/test.yml | Expands the host matrix and disables install scripts during npm ci. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Validation
On the official Pi 1.0.4 host: typecheck, all 118 tests, package dry-run and isolated native RPC loader passed. The PR matrix additionally checks the older supported hosts.
No production OAuth login, billable inference, npm publication or deployment was performed. Temporary lockfile-generation files have been removed from the final tree.