Skip to content

chore(build): drop hardcoded macOS signing team default#201

Closed
hughesyadaddy wants to merge 1 commit into
TomBadash:masterfrom
hughesyadaddy:chore/no-hardcoded-signing-defaults
Closed

chore(build): drop hardcoded macOS signing team default#201
hughesyadaddy wants to merge 1 commit into
TomBadash:masterfrom
hughesyadaddy:chore/no-hardcoded-signing-defaults

Conversation

@hughesyadaddy

@hughesyadaddy hughesyadaddy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the hardcoded Apple team ID fallback from \scripts/build_and_install_macos_app.sh.
  • macOS install builds now require an explicit \MOUSER_SIGN_IDENTITY\ or \MOUSER_TEAM_ID\ (or values from a gitignored .env.local).
  • Gitignore local QML probe tooling that defaults to machine-specific install paths.

Why

The install script shipped a developer-specific signing team ID as the default. That is local configuration, not something that belongs in the shared repo.

Test plan

  • On macOS with \MOUSER_SIGN_IDENTITY\ set: ./scripts/build_and_install_macos_app.sh\ still builds and installs.
  • With neither \MOUSER_SIGN_IDENTITY\ nor \MOUSER_TEAM_ID\ set: script fails fast with a clear error.
  • .env.local\ remains gitignored (.env.*\ in .gitignore).

…ults

Add a VS Code build task and macOS install helper that require explicit MOUSER_SIGN_IDENTITY or MOUSER_TEAM_ID (or gitignored .env.local values) instead of embedding a developer-specific Apple team ID. Gitignore local QML probe tooling.
@hughesyadaddy

Copy link
Copy Markdown
Contributor Author

Superseded by #202, which includes the signing-hygiene changes in the same branch. Closing to keep review in one place.

@hughesyadaddy hughesyadaddy deleted the chore/no-hardcoded-signing-defaults branch June 3, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant