Repository navigation
Fix Material localizations after material_ui migration - #1161
Open
MangelSpec wants to merge 1 commit into
Open
MangelSpec wants to merge 1 commit into
MangelSpec wants to merge 1 commit into
Conversation
- Register the material_ui delegates alongside the generated app delegate. - Cover German Material widgets with a focused regression test.
This was referenced Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was split out of #1153 following review so the background-fetch and localization fixes can be reviewed independently.
What was happening
After the
material_uimigration, opening KitchenOwl with a non-English locale could show a red exception screen.AppLocalizations.localizationsDelegatesstill contains the legacy delegates fromflutter_localizations. Those do not provide the localization types expected by widgets from the decoupledmaterial_uipackage.Emulator screenshot (German locale)
Exception and stack trace
The runner also reported:
What changed
AppLocalizations.delegatefor KitchenOwl's translated messages.GlobalMaterialLocalizations.delegatesfrommaterial_ui.GlobalMaterialLocalizations.delegatesincludes the Material, Cupertino, and Widgets delegates required by the decoupled UI packages.Verification
de-DE.