Skip to content

fix: register material_ui's own MaterialLocalizations delegates #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chlctt wants to merge 1 commit into from
Closed

fix: register material_ui's own MaterialLocalizations delegates #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions kitchenowl/lib/app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,18 @@ class _AppState extends State<App> with WidgetsBindingObserver {
),
onGenerateTitle: (BuildContext context) =>
AppLocalizations.of(context)!.appTitle,
// `material_ui` (used throughout this app instead of
// `flutter/material`) ships its own MaterialLocalizations
// implementation, separate from flutter_localizations'.
// AppLocalizations.localizationsDelegates only registers
// the latter, so material_ui's TextField can't find a
// MaterialLocalizations for any non-English locale and
// crashes with "Null check operator used on a null value"
// in _TextFieldState._getEffectiveDecoration. Register
// material_ui's own delegates too.
localizationsDelegates:
AppLocalizations.localizationsDelegates +
GlobalMaterialLocalizations.delegates +
[
LocaleNamesLocalizationsDelegate(),
],
Expand Down