Refactor code to reduce duplication and improve maintainability

[Copilot]

This PR addresses significant code duplication and improves the overall maintainability of the RNGChainingTool codebase through strategic refactoring.

Key Changes

1. Eliminated Code Duplication in Model Classes

The Method1 and MethodJ classes in models/queries.py had substantial duplication with identical attribute initialization. This has been resolved by:

• Moving shared attributes (min_frame, max_frame, natures, hidden_power_types, etc.) to the base VerifiableQuery class
• Implementing proper inheritance with super().__init__() calls
• Reducing the codebase by ~20 lines while maintaining full functionality

Before:

class Method1(VerifiableQuery):
    def __init__(self):
        self.min_frame = 0
        self.max_frame = 0
        self.natures = []
        # ... 10+ more identical attributes

After:

class Method1(VerifiableQuery):
    def __init__(self):
        super().__init__()  # Inherits all common attributes
        self.label = "Method1"

2. Centralized Configuration Management

Created constants.py to eliminate magic numbers and centralize default values:

# Default frame ranges
DEFAULT_MIN_FRAME = 1000
DEFAULT_MAX_FRAME = 2000

# Default IV values  
DEFAULT_MIN_IVS = "0/0/0/0/0/0"
DEFAULT_MAX_IVS = "31/31/31/31/31/31"

3. Streamlined GUI Creation

Introduced gui_helpers.py with reusable widget factory functions that significantly reduce repetitive code in the main GUI functions:

def create_entry_with_default(master, default_value):
    """Create an Entry widget with a default value."""
    entry = tk.Entry(master)
    entry.insert(0, str(default_value))
    return entry

def create_standard_entries(master):
    """Create common entry widgets used in both Method1 and MethodJ."""
    # Returns dictionary of pre-configured widgets

4. Simplified Main Functions

The add_method_j() and add_method_1() functions were refactored from 70+ and 25+ lines respectively to much more concise implementations using the new helper functions.

Benefits

• Reduced code duplication by approximately 50 lines across the codebase
• Improved maintainability - default values can be changed in one central location
• Better code organization - separated concerns into logical modules
• Enhanced readability - eliminated repetitive widget creation patterns
• Preserved functionality - all existing tests pass without modification
• No breaking changes - external interfaces remain unchanged

Testing

All existing unit tests continue to pass, confirming that the refactoring maintains full backward compatibility while improving code quality.

Fixes #2.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

@Tonychen0227 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.