Skip to content

White on White text #27

Description

@uutzinger

The information on the top level of the window is white on white when using light theme.

Image

The Back button used to leave Settings explicitly sets both its text and arrow to white, regardless of the theme:

style.text_color = Some(Color::WHITE);
style.icon_color = Some(Color::WHITE);

This is in [popup_view.rs (line 362). On a light background, it becomes unreadable.
The fix is to use the theme’s foreground color, as the other header buttons already do. No theme adjustment should be necessary.

Suggested change of code:
fn back_button_style(theme: &cosmic::Theme) -> widget::button::Style { let cosmic = theme.cosmic(); let mut style = widget::button::Style::new(); let foreground = component_on_color(theme); style.text_color = Some(foreground); style.icon_color = Some(foreground); style.border_radius = cosmic.corner_radii.radius_s.into(); style }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions