Treat missing Grok usage percent as empty window - #30
Merged
Merged
Conversation
Billing omits zero-valued usage scalars after a reset, so only a missing config preserves the prior snapshot. Document Grok fetch, mapping, and errors in spec §3.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grok was treating a 0% weekly window as missing usage. After a weekly reset the billing API omits creditUsagePercent (and sometimes GrokBuild usagePercent) because 0 is the default. YapCap mapped that to GrokError::NoUsageData, so the account showed Error plus Grok response had no usage windows while the last snapshot still rendered as 0.0% used / Reset.
Fix: if config is present, a missing, null, or zero percent is a valid Weekly 0% window. NoUsageData is only returned when config itself is absent.