Edited test_1 prompt to pass under gpt-3.5-turbo#7
Open
busse wants to merge 1 commit intoTorantulino:masterfrom
Open
Edited test_1 prompt to pass under gpt-3.5-turbo#7busse wants to merge 1 commit intoTorantulino:masterfrom
busse wants to merge 1 commit intoTorantulino:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_1 under gpt-3.5-turbo was failing because the model was returning single quotes instead of the proper double quotes in the JSON:
=-=-=- Running test: test_1 - Generate fake people with model gpt-3.5-turbo -=-=-= GPT RAW: [{'name': 'John', 'age': 25}, {'name': 'Jane', 'age': 32}, {'name': 'Bob', 'age': 19}, {'name': 'Alice', 'age': 47}] Output: [{'name': 'John', 'age': 25}, {'name': 'Jane', 'age': 32}, {'name': 'Bob', 'age': 19}, {'name': 'Alice', 'age': 47}] Testing if result is a a string... Testing if result can be parsed as a list of dictionaries... test_1: FAILED -Perhaps it was encountering a similar issue to this post -- single/double quotes are interchangeable in Python, but not JSON: https://stackoverflow.com/questions/4162642/single-vs-double-quotes-in-json
I have made a small edit to the
description_stringfor test_1, reminding GPT that JSON should have double quotes; to help disambiguate Python formatting vs. JSON formatting.I have edited the README as well.