Skip to content

Adding possibility for sputnik to load additional SpotBugs plugins like find-sec-bugs#229

Open
fipciu1996 wants to merge 22 commits intoTouK:masterfrom
fipciu1996:master
Open

Adding possibility for sputnik to load additional SpotBugs plugins like find-sec-bugs#229
fipciu1996 wants to merge 22 commits intoTouK:masterfrom
fipciu1996:master

Conversation

@fipciu1996
Copy link
Copy Markdown

This commit is adding the functionality of loading SpotBugs all plugins placed in the path passed to configuration.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2021

Codecov Report

Merging #229 (85dd88f) into master (f6aabbc) will decrease coverage by 0.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     72.38%   72.25%   -0.14%     
- Complexity      608      609       +1     
============================================
  Files           146      146              
  Lines          1988     2000      +12     
  Branches        131      133       +2     
============================================
+ Hits           1439     1445       +6     
- Misses          489      493       +4     
- Partials         60       62       +2     
Impacted Files Coverage Δ Complexity Δ
.../sputnik/processor/spotbugs/SpotBugsProcessor.java 75.00% <45.45%> (-6.14%) 13.00 <2.00> (+1.00) ⬇️
...a/pl/touk/sputnik/configuration/GeneralOption.java 98.43% <100.00%> (+0.02%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6aabbc...3654b91. Read the comment docs.

@SpOOnman SpOOnman force-pushed the master branch 2 times, most recently from 6694cfb to 4d9cc62 Compare January 13, 2021 14:11
Copy link
Copy Markdown
Contributor

@SpOOnman SpOOnman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your support. I've added my thoughts on your implementation, please review them. 😎

Comment thread src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java Outdated
Comment thread src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java Outdated
Comment thread src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java Outdated
Comment thread src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java Outdated
Comment thread src/test/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessorTest.java Outdated
Comment thread src/test/resources/test.properties Outdated
@fipciu1996 fipciu1996 requested a review from SpOOnman March 24, 2021 17:30
Copy link
Copy Markdown
Author

@fipciu1996 fipciu1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cleaned up code and I've implemented tests for my code.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2021

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.97%. Comparing base (3af8af7) to head (ee51538).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../sputnik/processor/spotbugs/SpotBugsProcessor.java 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     74.98%   74.97%   -0.02%     
- Complexity      662      668       +6     
============================================
  Files           154      154              
  Lines          2099     2118      +19     
  Branches        136      138       +2     
============================================
+ Hits           1574     1588      +14     
- Misses          460      464       +4     
- Partials         65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fipciu1996
Copy link
Copy Markdown
Author

Any news ?

@fipciu1996
Copy link
Copy Markdown
Author

Any news ?

This commit will add a lot to SpotBugs functionality inside the sputnik. For example, findsec-bugs are adding a lot of additional security rules that aren't currently possible to verify with basic SpotBugs.

@fipciu1996
Copy link
Copy Markdown
Author

@SpOOnman could you review this change again ? 🙏

@fipciu1996
Copy link
Copy Markdown
Author

Bump

1 similar comment
@fipciu1996
Copy link
Copy Markdown
Author

Bump

@fipciu1996
Copy link
Copy Markdown
Author

up

@fipciu1996
Copy link
Copy Markdown
Author

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants