Conversation
- Updated Rust version requirement to 1.87. - Modified dependencies: - `chrono` now has default features disabled with specific features enabled. - Updated `crossterm` to version 0.29. - Updated `rodio` to version 0.22.2 with default features disabled and specific features enabled. - Updated `ratatui` to version 0.30.0 with default features disabled and specific features enabled. - Updated `rusqlite` to version 0.39.0 with default features disabled and specific features enabled. - Updated `toml` to version 0.9.8. Refactor playback logic - Refactored playback handling in `playback.rs` and `control.rs` to use `MixerDeviceSink`. - Updated `build_sink` function to return `RodioPlayer` instead of `Sink`. - Adjusted the way tracks are played and seeked in the player. Enhance playlist management - Added logic to prevent duplicate tracks in the same playlist in `playlists.rs`. - Improved tests for playlist item addition to ensure duplicates are ignored. Code style improvements - Cleaned up formatting and improved readability in various files, including `modes.rs`, `normal.rs`, `chrome.rs`, `playback.rs`, `visualizer.rs`, and `playlists.rs`. - Ensured consistent use of match statements and formatting across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chrononow has default features disabled with specific features enabled.crosstermto version 0.29.rodioto version 0.22.2 with default features disabled and specific features enabled.ratatuito version 0.30.0 with default features disabled and specific features enabled.rusqliteto version 0.39.0 with default features disabled and specific features enabled.tomlto version 0.9.8.Refactor playback logic
playback.rsandcontrol.rsto useMixerDeviceSink.build_sinkfunction to returnRodioPlayerinstead ofSink.Enhance playlist management
playlists.rs.Code style improvements
modes.rs,normal.rs,chrome.rs,playback.rs,visualizer.rs, andplaylists.rs.Summary
Describe what changed and why.
Testing
cargo fmtcargo testcargo clippy --all-targets --all-features -- -D warningsDocs Impact
If docs follow-up is required, explain:
Release/Readiness Checklist
docs/README.mdor explicit release notes path)config/docs-sync-checklist.mdreviewed/updated for this change