feat: add Mantle and MantleTestnet to EthereumNetworks enum#31
feat: add Mantle and MantleTestnet to EthereumNetworks enum#31skydudie wants to merge 3 commits intoTradeTrust:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughReplaces a fixed-set enum validation for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
For this, we can remove the EthereumNetworks & EthereumNetowrkIdT type check, instead we can change it to numeric string type check.
There was a problem hiding this comment.
Replaced the checks with a numeric string type check: d5032b1
This pull request adds support for the Mantle mainnet and testnet Ethereum networks throughout the codebase. The changes ensure that Mantle networks (netId 5000 and 5003) are recognized and properly handled in both the core logic and the test suite.
Mantle network support:
mantle(netId 5000) andmantleTestnet(netId 5003) to theEthereumNetworksenum indnsTxt.ts, enabling recognition of these networks in the application logic.EthereumNetworkIdTunion type to include Mantle mainnet and testnet, ensuring type safety and validation for these new network IDs.Testing enhancements:
index.test.tsto verify that Mantle mainnet and testnet records are accepted byparseDocumentStoreResults.getDocumentStoreRecords for Astrontest, likely to ensure comprehensive coverage for multiple networks.Summary by CodeRabbit
New Features
Tests