Skip to content

🚸 show loading spinner on like button until request is confirmed #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrKrisKrisu merged 1 commit into from
Sep 27, 2026
Merged

🚸 show loading spinner on like button until request is confirmed #5111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions resources/tailwind-app/components/Status/StatusCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
} from '@lucide/vue';
import { trans } from 'laravel-vue-i18n';
import { DateTime } from 'luxon';
import { computed, onBeforeUnmount, onMounted, ref, watch } from 'vue';
import { Notyf } from 'notyf';
import { computed, inject, onBeforeUnmount, onMounted, ref, watch } from 'vue';
import { Api, Business, MentionDto, StatusResource, StopoverResource, UserResource } from '../../../types/Api.gen';
import LineIndicator from '../../../vue/components/LineIndicator.vue';
import TrwMap from '../../../vue/components/Map/Map.vue';
Expand Down Expand Up @@ -54,6 +55,7 @@

const api = new Api({ baseUrl: window.location.origin + '/api' });
const userStore = useUserStore();
const notyf = inject('notyf') as Notyf;

const statusObject = ref<StatusResource>(props.status);
const deleted = ref(false);
Expand All @@ -62,6 +64,7 @@
const progress = ref(0);
const interval = ref<number | null>(null);
const likes = ref(props.status.likes ?? 0);
const likePending = ref(false);

// next stop logic
const nextStop = ref<StopoverResource | null>(null);
Expand Down Expand Up @@ -201,20 +204,24 @@
});

function toggleLike() {
if (!userStore.user) return;
if (statusObject.value.liked) {
api.status.removeLikeFromStatus(statusObject.value.id).then(() => {
statusObject.value.liked = false;
likes.value--;
emit('status-unliked');
});
} else {
api.status.addLikeToStatus(statusObject.value.id).then(() => {
statusObject.value.liked = true;
likes.value++;
emit('status-liked');
});
}
if (!userStore.user || likePending.value) return;
likePending.value = true;
const wasLiked = statusObject.value.liked;
const request = wasLiked
? api.status.removeLikeFromStatus(statusObject.value.id)
: api.status.addLikeToStatus(statusObject.value.id);
request
.then(() => {
statusObject.value.liked = !wasLiked;
likes.value += wasLiked ? -1 : 1;
if (wasLiked) {
emit('status-unliked');
} else {
emit('status-liked');
}
})
.catch(() => notyf?.error(trans('generic.error')))
.finally(() => (likePending.value = false));
}

function onStatusUpdated(s: StatusResource) {
Expand Down Expand Up @@ -363,7 +370,7 @@
<p
v-if="statusObject.body"
class="text-base text-base-content/80 italic whitespace-pre-wrap break-words [font-synthesis:none]"
v-html="enrichedBody"

Check warning on line 373 in resources/tailwind-app/components/Status/StatusCard.vue

View workflow job for this annotation

GitHub Actions / ESLint Code Quality Check 

'v-html' directive can lead to XSS attack
/>

<!-- Moderation notices -->
Expand Down Expand Up @@ -493,10 +500,14 @@
<button
v-if="statusObject.isLikable"
class="flex items-center gap-1 text-xs text-base-content/40 hover:text-error transition-colors"
:class="{ 'text-error': statusObject.liked }"
:class="{ 'text-error': statusObject.liked || likePending }"
:aria-busy="likePending"
:disabled="likePending"
@click="toggleLike"
>
<span v-if="likePending" class="loading loading-spinner size-4" />
<Heart
v-else
class="inline-block size-4"
:class="statusObject.liked ? 'fill-error stroke-error' : 'stroke-current'"
/>
Expand Down
Loading