Skip to content

Fix non-unique request IDs when x-request-id header is absent in french-feedback - #2

Merged
TrainTravel merged 2 commits into
feat/ai-request-tracingfrom
copilot/sub-pr-1
Mar 2, 2026
Merged

Fix non-unique request IDs when x-request-id header is absent in french-feedback#2
TrainTravel merged 2 commits into
feat/ai-request-tracingfrom
copilot/sub-pr-1

Conversation

Copilot AI commented Mar 1, 2026

Copy link
Copy Markdown

When x-request-id is missing, all requests fell back to the literal "no-id", making them indistinguishable in logs and traces.

Changes

  • supabase/functions/french-feedback/index.ts
    • Replace "no-id" fallback with crypto.randomUUID() so every request is uniquely identifiable
    • Hoist requestId declaration above the try block so it's also available in the catch handler
    • Fix hardcoded [no-id] string in catch-block console.error to use the requestId variable
// Before
try {
  const requestId = req.headers.get("x-request-id") ?? "no-id";
  ...
} catch (error) {
  console.error(`[no-id] Error in french-feedback function:`, error);
}

// After
const requestId = req.headers.get("x-request-id") ?? crypto.randomUUID();
try {
  ...
} catch (error) {
  console.error(`[${requestId}] Error in french-feedback function:`, error);
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Mar 1, 2026
…-feedback

Co-authored-by: TrainTravel <25241752+TrainTravel@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on AI request tracing and structured client logging Fix non-unique request IDs when x-request-id header is absent in french-feedback Mar 1, 2026
@TrainTravel
TrainTravel marked this pull request as ready for review March 2, 2026 11:18
@TrainTravel
TrainTravel merged commit db503da into feat/ai-request-tracing Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants