feat: chrome translation — reflection flow (3 screens) - #46
Merged
Conversation
Adds Japanese, Simplified Chinese, and Traditional Chinese keys to the three post-write reflection screens: - ReflectionScreen.tsx - GratitudeScreen.tsx - FeedbackScreen.tsx ~16 t()/bilingual() sites total. Cherry-picked from the larger sweep branch (feat/chrome-translation-tier2-3) as a per-flow reviewable PR. The hard-coded isFr/isEs ternaries inside ReflectionScreen and FeedbackScreen are pre-existing technical debt (not t() calls) and remain out of scope for this pass — they'll be cleaned up in a follow-up that refactors them into proper t() sites. Register: polite Japanese (です・ます), neutral Mandarin (S/T distinguished where they differ). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
TrainTravel
force-pushed
the
feat/chrome-translation-reflection-flow
branch
from
May 27, 2026 00:49
71f9dad to
ab464fb
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Japanese, Simplified Chinese, and Traditional Chinese keys to the three post-write reflection screens.
Files (~16
t()/bilingual()sites total):ReflectionScreen.tsxGratitudeScreen.tsxFeedbackScreen.tsxCherry-picked from
feat/chrome-translation-tier2-3as a per-flow reviewable PR, following #44 / #45.Translation samples
Taking a moment to reflect...→少し考えています.../稍等，正在思考.../稍等，正在思考...Finish with gratitude→感謝で締めくくる/以感恩收尾/以感恩收尾Complete journal→日記を完了する/完成日记/完成日記A moment of clarity→澄んだひととき/清明片刻/清明片刻A small note→ひとこと/小提示/小提示Known carve-outs
The hard-coded
isFr ? : isEs ? : ...ternaries insideReflectionScreen.tsx(4 sites) andFeedbackScreen.tsx(1 site) are pre-existing technical debt — they bypasst()entirely, so they're outside this PR's chrome-translation scope. They'll be migrated to propert()calls in a follow-up.Test plan
tsc --noEmitpassesvitest run— 14 files / 198 tests passCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com