Skip to content

Search offers - the 'What' part - Trip based - 20260702#67

Open
edwinvandenbelt wants to merge 1 commit into
mainfrom
deliverables/search-offers-model
Open

Search offers - the 'What' part - Trip based - 20260702#67
edwinvandenbelt wants to merge 1 commit into
mainfrom
deliverables/search-offers-model

Conversation

@edwinvandenbelt

@edwinvandenbelt edwinvandenbelt commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds YAML data model files for the Search Offers deliverable (ContinuousLeg, DistributionFilter, FlexibilityFilter, Leg, LegAlight, LegBoard, LegIntermediate, Mode, SearchOfferFilter, SearchOfferPolicy, SearchOfferRequest, ServiceFilter, TimedLeg, TransferLeg, Trip, TripSection)

The request:
image

The Trip concepts:
image

@edwinvandenbelt edwinvandenbelt changed the title Add search offers deliverables Search offers - the 'What' part - Trip based Jun 22, 2026
@edwinvandenbelt edwinvandenbelt changed the title Search offers - the 'What' part - Trip based Search offers - the 'What' part - Trip based - 20260702 Jun 22, 2026
duration:
type: integer
description: Duration of the leg in minutes
individualMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ulf9 What is this? I don't see it in TM.

@TuThoThai TuThoThai Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be PersonalModeofOperations

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

individualMode:
type: string
enum: []
start:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startPlace?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep consistent with TimedLeg

start:
type: string
format: place-ref
end:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and endPlace?

type: string
description: discriminator for the leg type
const: continuous
continuousMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this one.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

mode:
type: string
description: Mode of transportation for the leg (e.g., bus, train, walking). See modes as specified in NeTEx.
enum: []

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a ref to Mode.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be clearer.

@@ -0,0 +1,28 @@
type: object
properties:
searchOfferId:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 'allOf' + request.yaml. The searchOfferId = requestId

description: Reference to the operating day associated with this leg
format: day-of-week
enum: [Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday]
privateMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, what does this mean?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make consistent with Transmodel: PersonalModesOfOperationEnumeration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it might not be needed in the TimedLeg

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

privateMode:
type: string
enum: []
ptMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't 'mode' on the Leg level (as specified) enough?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

type: string
description: discriminator for the leg type
const: transfer
continuousMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again, I don't know what should be in here. There is already 'mode' at leg level, what does this mode mean?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

duration:
type: integer
description: Duration of the leg in minutes
transferMode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again, I don't know what should be in here. There is already 'mode' at leg level, what does this mode mean?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

transferMode:
type: string
enum: []
start:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startPlace?

start:
type: string
format: place-ref
end:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endPlace?

@OlivierBigex

Copy link
Copy Markdown
Collaborator

If there is a trip pattern section, is the retailer supposed to provide to the distributor the complete trip, even sections that are not covered by the distributor (in case of multi-distributor trip) ?

- "ISO/IEC 7816-4" # NFC, MIFARE DESFire
- "GATT" # Bluetooth Low Energy
- "AXA Bike lock" # AXA Bike lock
- "OTHER" # Other content standard

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is calypso card somewhere in that list ?

- "ISO/IEC 7816-4" # NFC, MIFARE DESFire
- "GATT" # Bluetooth Low Energy
- "AXA Bike lock" # AXA Bike lock
- "OTHER" # Other content standard

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be interesting to avec an object for the Fulfillment Storage Location (or something more accurate): ON_MEDIA, ON_SYSTEM. Indicating if the ticket is technically stored in the media or in system.

description: The channel of the offer.
x-enum-values:
- "web"
- "mobile"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app ?

allOf:
- $ref: .\Leg.yaml
- type: object
properties:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add:

  • modeOfOperation: enum, to be found in OJP/NeTEx. (fixed)

enum: []
sequenceNumber:
type: integer
description: The order of the leg in the overall journey. In case of parallel legs, the sequence number should be the same for those legs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further discussion / modelling is needed on the concept of parallel leg especially if we are taking into account parking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants