Search offers request & delivery (overarching) - 20260702#71
Open
edwinvandenbelt wants to merge 1 commit into
Open
Search offers request & delivery (overarching) - 20260702#71edwinvandenbelt wants to merge 1 commit into
edwinvandenbelt wants to merge 1 commit into
Conversation
edwinvandenbelt
changed the title
edwinvandenbelt
changed the title
edwinvandenbelt
changed the title
edwinvandenbelt
commented
Jul 2, 2026
| | travellers | List of travellingEntities | required | See the 'Who' part | | ||
| | trip | Trip | required | See the 'What' part | | ||
| | filters | List of Filters | optional | See the PR of the 'What' part | | ||
| | amendingOfferedPackageRef | string | conditional | (policy) only to be used in the 'amend' phase, where additional offers can be searched | |
Collaborator
Author
There was a problem hiding this comment.
Stalled, until the BUC comes in
edwinvandenbelt
commented
Jul 2, 2026
| | trip | Trip | required | See the 'What' part | | ||
| | filters | List of Filters | optional | See the PR of the 'What' part | | ||
| | amendingOfferedPackageRef | string | conditional | (policy) only to be used in the 'amend' phase, where additional offers can be searched | | ||
| | contentLanguage | string | optional | (policy) The language/localization of user-facing content, One IETF BCP 47 (RFC 5646) language tag. If missing, the local accepted language | |
Collaborator
Author
There was a problem hiding this comment.
Clemens: This should be a list.
Contributor
There was a problem hiding this comment.
Clarification: it should be a list of values.
The admitted values is the ISO code for languages (2-letters)
TuThoThai
reviewed
Jul 2, 2026
| | filters | List of Filters | optional | See the PR of the 'What' part | | ||
| | amendingOfferedPackageRef | string | conditional | (policy) only to be used in the 'amend' phase, where additional offers can be searched | | ||
| | contentLanguage | string | optional | (policy) The language/localization of user-facing content, One IETF BCP 47 (RFC 5646) language tag. If missing, the local accepted language | | ||
| | currency | string | optional | (policy) The currency to be used in the response. If the requested currency is not available, return the local valuta | |
Contributor
There was a problem hiding this comment.
Note: usually, only one currency (the one of the distributor) is allowed. However, some systems can have other currencies displayed
Collaborator
There was a problem hiding this comment.
the other displayed currency is for information and additionaly to the main one from the distributor.
change to "The additional currency to be used in the response"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overarching PR, connecting the dots between the 'who' and the 'what'. Keep in mind that the what (for now) is only the trip-based search offer request. The other variants will be published later.
Request