Enhancing ActionData#221
Conversation
- Change in `Prompt` to embed MIME content type - Addition of `Url` with a specific type to embed MIME content type and language - All served with an example
TuThoThai
added
SX
|
I would prefer that the Prompt itself is not changed in function. Hence if an organisation wants to do something with predefined markup that is fine, they can use Url |
|
Since |
thbar
left a comment
thbar
left a comment
There was a problem hiding this comment.
I did a first round mostly on "details". I will mull over the general design & see if I can comment more on the overall structure (need more time).
| @@ -1,4 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- edited with XMLSpy v2025 (x64) (https://www.altova.com) by Tu-Tho Thai (Private) --> | |||
There was a problem hiding this comment.
| <!-- edited with XMLSpy v2025 (x64) (https://www.altova.com) by Tu-Tho Thai (Private) --> |
Presumably we want this removed?
| @@ -0,0 +1,131 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |||
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> | |||
There was a problem hiding this comment.
The example uses things only found in the upcoming v2.3.0, so presumably this should be (?):
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> | |
| <Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.3.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd"> |
| @@ -0,0 +1,131 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |||
There was a problem hiding this comment.
| <!-- (C) Copyright 2005-2012 CEN SIRI --> | |
| <!-- (C) Copyright 2005-2026 CEN SIRI --> |
| </xsd:annotation> | ||
| <xsd:simpleContent> | ||
| <xsd:extension base="NaturalLanguageStringStructure"> | ||
| <xsd:attribute name="content-type" type="xsd:string" default="text/plain" use="optional"> |
There was a problem hiding this comment.
I believe having an attribute cased like content-type (instead of camelCase contentType) is not common in this codebase ; also it feels off in XML in general. Although it maps a HTTP header with that exact name, I would probably go camelCase:
| <xsd:attribute name="content-type" type="xsd:string" default="text/plain" use="optional"> | |
| <xsd:attribute name="type" type="xsd:string" default="text/plain" use="optional"> |
(and adapt accordingly elsewhere)
|
During the SIRI-SX meeting of 19 may 2026, the assessment was that the PR is not yet ready for review. Discussed changes / paints points are to be addressed. |
3 participants
Promptto embed MIME content typeUrlwith a specific type to embed MIME content type and languageThis PR is to be discussed and merged before PR #210 that adds
PublishToAudioAction. To includeUrlinActionDataaddresses @skinkie comment