fix(ci): pin Rust toolchain, fix gitignore gaps, remove stale workflow - #370
Merged
ALLEN-AYODEJI merged 2 commits intoAug 30, 2026
Conversation
- Create rust-toolchain.toml pinning stable 1.86.0 with wasm32-unknown-unknown target and rustfmt/clippy components for reproducible builds (Trellis-Ecosystem#308) - Remove dtolnay/rust-toolchain step from contract-ci.yml; toolchain file is read automatically by rustup, eliminating the duplicate install step (Trellis-Ecosystem#308) - Add rust-toolchain.toml to contract-ci.yml path triggers (Trellis-Ecosystem#308) - Update dependabot.yml with note that cargo ecosystem covers toolchain pin (Trellis-Ecosystem#308) - Add frontend/dist/ to root .gitignore to prevent tracking build artifacts (Trellis-Ecosystem#309) - Add frontend/.env, frontend/.env.local, frontend/.env.*.local to root .gitignore as a safety net against accidental secret commits (Trellis-Ecosystem#310) - Add Environment Files and Secrets section to SECURITY.md documenting all ignored .env patterns and rotation guidance (Trellis-Ecosystem#310) - Delete .github/workflows/frontend.yml — superseded by frontend-ci.yml which includes workflow_dispatch, Node matrix, concurrency, and artifact upload (Trellis-Ecosystem#311) Closes Trellis-Ecosystem#308 Closes Trellis-Ecosystem#309 Closes Trellis-Ecosystem#310 Closes Trellis-Ecosystem#311
|
@graceuvala-collab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four maintenance issues in a single cohesive change.
Changes
#308 — Pin Rust Toolchain with
rust-toolchain.tomlrust-toolchain.tomlat the repo root pinningchannel = "1.86.0",targets = ["wasm32-unknown-unknown"], andcomponents = ["rustfmt", "clippy"]. rustup reads this file automatically in any subdirectory.dtolnay/rust-toolchainstep from.github/workflows/contract-ci.yml— the toolchain file supersedes it, eliminating the duplicate install.rust-toolchain.tomltocontract-ci.ymlpath triggers so CI reruns on toolchain version bumps.dependabot.ymlwith a comment noting the existingcargoecosystem entry also covers the toolchain pin.#309 — Add
frontend/dist/to.gitignorefrontend/dist/to the root.gitignore. The directory was not tracked (confirmed withgit ls-files), so nogit rm --cachedwas needed.#310 — Add
frontend/.envpatterns to.gitignorefrontend/.env,frontend/.env.local, andfrontend/.env.*.localto the root.gitignoreas an explicit safety net (thefrontend/.gitignorealready covered.envand*.local, but root-level rules prevent any git-resolution edge cases).SECURITY.mddocumenting all ignored.envpatterns, their contents, and secret-rotation guidance.#311 — Remove stale
frontend.ymlworkflow.github/workflows/frontend.yml.frontend-ci.ymlis the canonical workflow and already includesworkflow_dispatch, a Node 20/22 matrix, concurrency cancellation, and artifact upload.frontend-ci.yml— no badge change required.Verification
git ls-files frontend/dist/ frontend/.envreturns empty — no artifacts or secrets were tracked before or after.rust-toolchain.tomlfollows the rustup override spec.Closes #308
Closes #309
Closes #310
Closes #311