fix(ci): reproducible builds and release version validation - #376
Open
Coredevjay wants to merge 1 commit into
Open
fix(ci): reproducible builds and release version validation#376Coredevjay wants to merge 1 commit into
Coredevjay wants to merge 1 commit into
Conversation
- Add --frozen to all cargo build/test/clippy commands in the Makefile, contract-ci.yml, and release.yml so CI/local builds fail if Cargo.lock is out of date instead of silently regenerating it. - Replace npm install with npm ci in Makefile frontend targets for lockfile-exact dependency installs. - Add make fmt, make typecheck-frontend, and make setup targets. - Add a verify-version job to the release workflow that fails the release if the pushed tag doesn't match Cargo.toml (CLI/contract) or frontend/package.json versions. Closes Trellis-Ecosystem#316 Closes Trellis-Ecosystem#317 Closes Trellis-Ecosystem#318 Closes Trellis-Ecosystem#320
|
@Coredevjay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--frozento allcargo build/test/clippycommands in the Makefile,contract-ci.yml, andrelease.ymlso builds fail on a staleCargo.lockinstead of silently updating it.npm installwithnpm ciin the Makefile'sbuild-frontend,test-frontend, andlint-frontendtargets for reproducible, lockfile-exact installs.make fmt,make typecheck-frontend, andmake setuptargets.verify-versionjob to the release workflow that compares the pushed git tag againstcli/trellis_cli/Cargo.toml,contracts/trellis_core/Cargo.toml, andfrontend/package.jsonversions, and fails the release on any mismatch before the build jobs run.Closes #316
Closes #317
Closes #318
Closes #320
Validation performed
make -n <target>dry-run for every changed/new Makefile target to confirm correct command expansion.release.ymlandcontract-ci.yml.Cargo.lockandfrontend/package-lock.jsonare committed and in sync with current manifest versions (0.1.0 across CLI, contract, and frontend), so--frozenwon't break existing CI.cargois not available in this sandbox, socargo build --frozenitself could not be executed locally; CI (contract-ci.yml) will validate it on push.