Repository navigation
fix: restore Tidal session robustly + countryCode US fallback in plug… - #60
Closed
springjools wants to merge 1 commit into
Closed
springjools wants to merge 1 commit into
springjools wants to merge 1 commit into
Conversation
…in TidalAPI Root cause of 'error processing feed' / 0 results / indexer auto-disabled: CheckForStoredUser() set a valid ActiveUser then called GetSession(); any throw there hit the blanket catch and discarded the valid restored user -> Login() false -> GetRequestGenerator() null -> Lidarr core NRE. Now GetSession is best-effort and the restored tokens are kept. Also mirror PR TrevTV#54's countryCode->US fallback in the plugin's own TidalAPI.GetAPIUrl (PR TrevTV#54 only patched TidalSharp/API.cs); the search path uses this builder and sent an empty countryCode before sessionInfo was populated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Sorry, wrong repo. Wanted to test this locally and merge into my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in TidalAPI
Root cause of 'error processing feed' / 0 results / indexer auto-disabled: CheckForStoredUser() set a valid ActiveUser then called GetSession(); any throw there hit the blanket catch and discarded the valid restored user -> Login() false -> GetRequestGenerator() null -> Lidarr core NRE. Now GetSession is best-effort and the restored tokens are kept.
Also mirror PR #54's countryCode->US fallback in the plugin's own TidalAPI.GetAPIUrl (PR #54 only patched TidalSharp/API.cs); the search path uses this builder and sent an empty countryCode before sessionInfo was populated.