Fix team-owned invoice edit permissions#669
Open
Fanwize wants to merge 1 commit intoTreyWW:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a permission bug in the invoice edit endpoint for team-owned invoices.
The endpoint previously performed manual permission checks against both the active team and the invoice user. For team-owned invoices,
invoice.organizationis set whileinvoice.usermay be empty. This meant that a user logged in as the owning team could still be incorrectly rejected with a 403 response.This PR replaces the duplicated manual permission check with the existing
invoice.has_access(request.user)helper, which already handles both personal and team-owned invoices.Regression tests were added for:
No new dependencies are required.
Checklist
djLint-er on any new code
changes
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc