test: cover formatting at both extremes - #207
Closed
ZacLou wants to merge 1 commit into
Closed
Conversation
ZacLou
force-pushed
the
test/issue-148
branch
from
September 1, 2026 09:21
09d17e7 to
e97900b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Adds explicit coverage for the two formatting boundaries called out in the issue:
formatAmount("0")returns"0"instead of an empty string.The existing suite already handled empty string as zero and a large value; these cases make the zero and near-maximum boundaries explicit and fail if the formatter is removed or regresses.
npm run test -- lib/format.test.tsandnpm run typecheckpass.npm run lintreports pre-existing errors in unrelated files.