refactor: extract magic numbers into constants - #212
Closed
ZacLou wants to merge 1 commit into
Closed
Conversation
Replaces repeated numeric literals with named constants from lib/constants: - MS_PER_SECOND for Unix/JS timestamp conversions - SECONDS_PER_MINUTE / HOUR / DAY for duration math - STREAM_LIST_REFRESH_INTERVAL_MS for the 15s background refresh - MAX_CONFIRMATION_ATTEMPTS / CONFIRMATION_POLL_INTERVAL_MS / TRANSACTION_BUILDER_TIMEOUT_SECONDS for on-chain polling Closes TricklePay#156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156
Replaces repeated numeric literals with named constants from lib/constants.ts so values and their meaning live together and the tuning surface is obvious:
No behavioural changes.
Verification
px vitest run lib/format.test.ts lib/validation.test.ts lib/timezone.test.ts lib/amount.test.ts — 72 tests pass
pm run typecheck — only pre-existing errors in components/skeleton.test.tsx`n-
pm run lint — only pre-existing errors in test files