Fix Incorrect NodeLL Type Selection for Lat/Lon Offsets to Prevent Encoding Failures#8

Merged

payneBrandon merged 32 commits intodevfrom

fix/node-ll-selection

Apr 18, 2025

Commits on Mar 19, 2025

Added passing unit tests for `transformNodeLL` and `nodeOffsetPointLL` methods in TravelerMessageFromHumanToAsnConverter
dmccoystephenson
committed
Added failing unit test for `transformNodeLL` when LL type is not specified
dmccoystephenson
committed
Added failing unit test for `nodeOffsetPointLL` for input lat/lon `-13123, -8192`
dmccoystephenson
committed

Commits on Mar 20, 2025

Added more unit tests for `nodeOffsetPointLL` method, some of which are failing
dmccoystephenson
committed
Updated LL_5_MINIMUM_MICRO_DEGREES & LL_6_MINIMUM_MICRO_DEGREES to correct values
dmccoystephenson
committed
Updated some test values & added comments
dmccoystephenson
committed
Updated naming convention for new tests for clarity
dmccoystephenson
committed
Added descriptive failure messages to nodeOffsetPointLL unit tests for improved debugging clarity
dmccoystephenson
committed
Updated test values outside LL constraints
dmccoystephenson
committed
Fixed failing unit tests by adding missing parentheses to `nodeOffsetPointLL` method
dmccoystephenson
committed
Refactored bitmask range validation by extracting methods and improving names for clarity
dmccoystephenson
committed
Renamed `nodeOffsetPointLL` method to `determineNodeOffsetPointLLType`
dmccoystephenson
committed
Introduced constants for NODE_LL types and added JavaDocs
dmccoystephenson
committed
Updated JavaDocs
dmccoystephenson
committed
Refactored `determineNodeOffsetPointLLType` to check numerical limits instead of using bitwise operations
dmccoystephenson
committed
Added J2735 note regarding the value -8388608
dmccoystephenson
committed
Formatted TravelerMessageFromHumanToAsnConverter.java
dmccoystephenson
committed
Formatted TravelerMessageFromHumanToAsnConverterTest.java
dmccoystephenson
committed
Addressed a couple warnings in TravelerMessageFromHumanToAsnConverter class
dmccoystephenson
committed
Reindented TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes with 2 spaces
dmccoystephenson
committed
Reformatted TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes
dmccoystephenson
committed
Removed unnecessary imports, initializations, casts & throws lists in TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes
dmccoystephenson
committed
Renamed unit tests
dmccoystephenson
committed
Updated illegal argument exception message
dmccoystephenson
committed
Updated `determineNodeOffsetPointLLType` to throw custom InvalidNodeLatLonOffsetException instead of IllegalArgumentException
dmccoystephenson
committed
Added JavaDocs for InvalidNodeLatLonOffsetException
dmccoystephenson
committed
Updated catch block in TimDepositController for InvalidNodeLatLonOffsetException to prevent printing stack trace
dmccoystephenson
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Incorrect NodeLL Type Selection for Lat/Lon Offsets to Prevent Encoding Failures#8

Fix Incorrect NodeLL Type Selection for Lat/Lon Offsets to Prevent Encoding Failures#8
payneBrandon merged 32 commits intodevfrom
fix/node-ll-selection

Commits on Mar 19, 2025

Added passing unit tests for `transformNodeLL` and `nodeOffsetPointLL` methods in TravelerMessageFromHumanToAsnConverter

Added failing unit test for `transformNodeLL` when LL type is not specified

Added failing unit test for `nodeOffsetPointLL` for input lat/lon `-13123, -8192`

Commits on Mar 20, 2025

Added more unit tests for `nodeOffsetPointLL` method, some of which are failing

Updated LL_5_MINIMUM_MICRO_DEGREES & LL_6_MINIMUM_MICRO_DEGREES to correct values

Updated some test values & added comments

Updated naming convention for new tests for clarity

Added descriptive failure messages to nodeOffsetPointLL unit tests for improved debugging clarity

Updated test values outside LL constraints

Fixed failing unit tests by adding missing parentheses to `nodeOffsetPointLL` method

Refactored bitmask range validation by extracting methods and improving names for clarity

Renamed `nodeOffsetPointLL` method to `determineNodeOffsetPointLLType`

Introduced constants for NODE_LL types and added JavaDocs

Updated JavaDocs

Refactored `determineNodeOffsetPointLLType` to check numerical limits instead of using bitwise operations

Added J2735 note regarding the value -8388608

Formatted TravelerMessageFromHumanToAsnConverter.java

Formatted TravelerMessageFromHumanToAsnConverterTest.java

Addressed a couple warnings in TravelerMessageFromHumanToAsnConverter class

Reindented TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes with 2 spaces

Reformatted TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes

Removed unnecessary imports, initializations, casts & throws lists in TravelerMessageFromHumanToAsnConverter & TravelerMessageFromHumanToAsnConverterTest classes

Renamed unit tests

Updated illegal argument exception message

Updated `determineNodeOffsetPointLLType` to throw custom InvalidNodeLatLonOffsetException instead of IllegalArgumentException

Added JavaDocs for InvalidNodeLatLonOffsetException

Updated catch block in TimDepositController for InvalidNodeLatLonOffsetException to prevent printing stack trace

Commits on Mar 24, 2025

Renamed `determineNodeOffsetPointLLType` to `getNodeOffsetPointLLType`

Referenced constants instead of using magic strings for nodeLL types

Changed some accessors to protected instead of public

Made `nonCompliantFields` list a static instance variable & reformatted the list

Specified `annotationProcessorPaths` in the root pom.xml