Vendor and Bot banning#1140
Open
silent-decibel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a vendor is banned, certain processes, like sending the user a DM or creating a mod thread, are ignored. The same logic has been applied to when a mod user bans a bot (makes sense and was also requested). This change sees that vendors and bots are treated exactly the same when a ban action is applied.
Secondly, when a mod uses the report slash command, two new buttons - Vendor and Bot - have been added. Clicking on one or the other will still open the mod modal, but the ban reason and message delete days are pre-filled. This makes the banning of vendors and bots a bit faster and was met with approval when brought up with the mod team.
Considering maybe skipping the mod modal for vendor / bot bans in the future, but this comes with a few risks and would need to be fleshed out more.