Fix nav strings#16
Conversation
Introduce full assignments flow: AddAssignmentActivity, AssignmentAdapter, layouts, and strings. Register new activity in AndroidManifest and add FAB in schedule layout to open the add screen. Wire ScheduleActivity to AssignmentViewModel/Room repository, hook up RecyclerView with checkbox handling and sorted list display, and add item_assignment updates (checkbox, course name, styling). Fix AppDatabase singleton initialization to ensure a single instance, plus small runtime fixes (CameraActivity surface provider change, simplified network check in MainActivity) and minor ViewModel factory/comment tweaks. Also include small IDE config updates.
New update! what's new: Add navigation string resources (Home, Tasks, Map, Scanner, Lectures) to app/src/main/res/values/strings.xml. Correct a Gradle property in gradle.properties (replace android.disallowKotlinSourceSets with android.disallowKotlinSource) and bump KSP from 2.3.2 to 2.3.6 in gradle/libs.versions.toml.
jerrya-code
requested review from
Trosper3 and
Copilot
and removed request for
Copilot
Trosper3
left a comment
Trosper3
left a comment
There was a problem hiding this comment.
I see your KSP is a newer version. Thanks for that. I will get it merged, pulled, and see if I need to update AGP.
There was a problem hiding this comment.
Pull request overview
Fixes build/runtime issues by updating Gradle/Kotlin-related configuration and adding missing navigation string resources.
Changes:
- Updated the KSP version in the Gradle versions catalog.
- Adjusted Gradle properties related to Kotlin source set configuration.
- Added missing navigation string resources required by the app.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates KSP version used by the build. |
| gradle.properties | Changes Kotlin/Android Gradle property configuration. |
| app/src/main/res/values/strings.xml | Adds missing nav string resources to prevent runtime/resource failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| android.nonTransitiveRClass=true | ||
| android.disallowKotlinSourceSets=false | ||
|
|
||
| android.disallowKotlinSource=false |
There was a problem hiding this comment.
This appears to be a typo/regression from the previous android.disallowKotlinSourceSets property. android.disallowKotlinSource is likely not a recognized Android Gradle property, so it may be ignored and fail to achieve the intended behavior (and could mask the original fix). Consider restoring android.disallowKotlinSourceSets=false (or updating to the correct current property name per the AGP version used) instead of introducing a new, potentially unsupported key.
| android.disallowKotlinSource=false | |
| android.disallowKotlinSourceSets=false |
New update!
Bug fixes: