fix: avoid mutating global csv dialect in run_csv_view fallback#52
Merged
AkshajSinghal merged 1 commit intoJun 8, 2026
Merged
Conversation
When csv.Sniffer().sniff() fails, the fallback code called
csv.get_dialect('excel') which returns the class itself, then mutated
.delimiter on it. This permanently corrupted the global excel dialect
for the process lifetime, affecting all subsequent CSV operations.
Fix: use the built-in csv.excel_tab and csv.excel dialects directly
based on the detected delimiter, avoiding any mutation.
Closes TruFoundation#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
csv.Sniffer().sniff()fails inrun_csv_view(), the fallback code callscsv.get_dialect('excel')which returns the class itself (not an instance), then mutates.delimiteron it. This permanently corrupts the global excel dialect for the process lifetime, affecting all subsequent CSV operations.Closes #47
Fix
Use the built-in
csv.excel_tabandcsv.exceldialects directly based on the detected delimiter, avoiding any mutation of global state.Testing