Skip to content

Fix profile reply stats display#2727

Closed
guaka wants to merge 8 commits into
mainfrom
cursor/remove-profile-reply-rate
Closed

Fix profile reply stats display#2727
guaka wants to merge 8 commits into
mainfrom
cursor/remove-profile-reply-rate

Conversation

@guaka

@guaka guaka commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fix the profile sidebar reply stats instead of removing reply rate
  • render reply time as the formatted duration returned by the API, for example 3 hours
  • keep displaying reply rate, including 0%, and add focused component coverage

Validation

  • npm run test:client -- modules/users/tests/client/components/ProfileViewBasics.tests.js
  • NODE_OPTIONS="--require /private/tmp/jest.hide-canvas.js" ./node_modules/.bin/jest modules/users/tests/client/components/ProfileViewBasics.tests.js --no-watchman --runInBand
  • ./node_modules/.bin/eslint modules/users/client/components/ProfileViewBasics.js modules/users/tests/client/components/ProfileViewBasics.tests.js

Notes

  • Existing unrelated commits/files remain in this PR from before this fix, including CI workflow updates, local Docker config, and signup test updates.
  • cursor/fix-profile-reply-stats points at the same new commit as the PR head.

@guaka guaka deleted the branch main June 12, 2026 21:28
@guaka guaka closed this Jun 12, 2026
@guaka guaka reopened this Jun 12, 2026
@guaka guaka changed the base branch from master to main June 12, 2026 21:37
@guaka guaka closed this Jun 12, 2026
@guaka guaka deleted the cursor/remove-profile-reply-rate branch June 12, 2026 21:52
@guaka guaka reopened this Jun 12, 2026
@guaka guaka changed the title Remove reply rate from profile sidebar Fix profile reply stats display Jun 12, 2026
@guaka guaka added run-e2e add this label to a PR if you want the e2e tests to run helpful for support labels Jun 12, 2026
…cursor/fix-profile-reply-stats

# Conflicts:
#	.github/workflows/lint.yml
#	.github/workflows/test.yml
#	deploy/docker/docker-compose.yml
#	modules/core/server/routes/core.server.routes.js
#	modules/experiences/tests/client/components/CreateExperience.client.component.tests.js
#	modules/tribes/tests/client/components/TribesPage.component.tests.js
#	modules/users/tests/client/components/ProfileViewBasics.tests.js
#	modules/users/tests/server/user-signup.server.routes.tests.js
@guaka

guaka commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2742 so the PR uses the correctly named branch cursor/fix-profile-reply-stats.

@guaka guaka closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helpful for support run-e2e add this label to a PR if you want the e2e tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant