devcontainer settings#2732
Open
awongh wants to merge 3 commits into
Open
Conversation
Contributor
|
I found one integration issue in the devcontainer merge: the shared deploy/docker .env sets COMPOSE_PROJECT_NAME=trustroots, which Docker Compose treats as a CLI-level project-name override. Because the devcontainer consumes deploy/docker/docker-compose.yml first, that env value wins over the devcontainer overlay's name and can make the devcontainer share the normal local stack's project/network/volumes. I'll fix this by making the shared stack use an interpolated Compose name with the same default, while leaving COMPOSE_PROJECT_NAME free for callers/tools to override when they really mean to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.