-
Notifications
You must be signed in to change notification settings - Fork 16
Changed account editing section to use Stripe billing portal data attribute #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation in the members theme file was updated to reflect managing billing and receipts via the Stripe customer portal. Wording changed from "Edit billing info" to "Manage billing & receipts". A data attribute was renamed from Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@themes/members.mdx`:
- Around line 423-427: The anchor uses the old attribute name
data-members-edit-billing while the earlier example uses
data-members-manage-billing; update the anchor element to use the consistent
attribute data-members-manage-billing (replace data-members-edit-billing with
data-members-manage-billing) so both examples match and readers aren’t confused;
locate the anchor with the existing attributes data-members-return and the link
text "Manage billing & receipts" to apply the change.
…ribute closes [GVA-649](https://linear.app/ghost/issue/GVA-649/update-docs-for-portal-billing-manage-billing-attribute) We do still support the old edit-billing attribute, but this is the new way of accessing the full Stripe customer billing portal instead of the card update flow.
541875c to
1f40448
Compare
aileen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
closes GVA-649
We do still support the old edit-billing attribute, but this is the new way of accessing the full Stripe customer billing portal instead of the card update flow.