test: reproduce pre-ack QSS auth sync loss (#3376) - #3377
Draft
holmesworcester wants to merge 1 commit into
Draft
Conversation
Add a focused red regression test showing that an AUTH_SYNC frame received before auth connection initialization is discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AUTH_SYNCframe arriving before the per-communityQSSAuthConnectionis initialized.Diagnosis
On notification-driven iOS startup, QSS can emit its first
AUTH_SYNCframe beforeSIGN_IN_COMMUNITYis acknowledged.QSSServicestarts the auth connection only after that acknowledgement. Meanwhile,QSSAuthConnectionManagerhandles the early frame, finds no active connection, logs an error, and discards it without queuing or replaying it. The auth handshake then continues without its first frame; the attached issue logs subsequently showDEVICE_UNKNOWNand a QSS disconnect.The issue logs capture this exact ordering:
16:25:20.807: client sendsSIGN_IN_COMMUNITY16:25:20.950: first auth frame is rejected because the auth connection “wasn't initialized”16:25:20.952: auth connection is initialized16:25:22.037: server returnsDEVICE_UNKNOWN, then QSS disconnectsTest
Expected red result proving the dropped frame:
Prettier, ESLint, and
git diff --checkpass. This PR contains no production fix.