fix: Clear connected peers interval on pause and ensure libp2p doesn't redial after pause - #3385
Open
islathehut wants to merge 6 commits into
Open
fix: Clear connected peers interval on pause and ensure libp2p doesn't redial after pause#3385islathehut wants to merge 6 commits into
islathehut wants to merge 6 commits into
Conversation
islathehut
marked this pull request as ready for review
July 27, 2026 15:34
adrastaea
requested changes
Jul 27, 2026
| this.connectedPeers.clear() | ||
| // await this.libp2pDatastore?.deleteKeysByPrefix(Libp2pDatastorePrefix.PEERS) | ||
| // remove peers from the datastore to avoid libp2p auto-redialing after the pause | ||
| await this.libp2pDatastore?.deleteKeysByPrefix(Libp2pDatastorePrefix.PEERS) |
Collaborator
There was a problem hiding this comment.
This is currently a no-op because peers does not match /peers/, so nothing is deleted. Also, deleting the entire peer namespace will also delete the self records, so that could be detrimental. It would be better to enumerate the peer records and use the .delete() api to clear remote peer records. The test you added just proves that this command is called, not that it actually deleted the records which is why it is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: