Feature/2422 emoji only message font size - #3414
Open
kingalg wants to merge 3 commits into
Open
Conversation
holmesworcester
approved these changes
Aug 24, 2026
holmesworcester
left a comment
Collaborator
There was a problem hiding this comment.
Approved, but if you'd like to do this bonus item from the linked issue, that would be great!
I don't know if desktop does this yet but I think it does
Bonus: in-line emojis should have a larger font size too. (Slack seems to render them as images at 22px.)
Collaborator
Author
|
TLDR: @holmesworcester the requested change is done; tests are modified and slightly improved; It wasn’t done on desktop, and we still need to do it. This turned out to be bigger than I thought (or I kept running into things I wanted to fix). Several points to explain:
Changes that I’ve made:
|
holmesworcester
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes #2422 — emoji-only messages now render at fontSize: 28 instead of the default 14, matching existing desktop behavior (#519 ).
I had a dilemma about what to do with tests because we have a disabled message.test already but at the end decided on the following approach:
New test file vs. reviving Message.test.disabled.tsx: that file is a pre-existing, already-broken ~1400-line snapshot (avatar SVG + MathJax rendering), disabled during a past RN upgrade and not run by Jest. Fixing it properly is a separate, unrelated effort, so it's left untouched — flagged in-line with a one-line comment pointing at it so it's not mistaken for overlapping coverage. I'm gonna check and, if needed and it's not created yet, create an issue to fix the disabled test.