fix: Add baseline subtraction for global config diffs#26
Merged
Conversation
Global config changes (default.yml/base.yml) were not subtracted, causing MRs touching global config to show all pending undeployed changes. Now applies subtractConfigChanges and subtractResourceDiff to the global diff block. Also merges base branch base.yml with env overlay for baseline global parsing. Ref #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subtractConfigChanges()for org_settings/agent_options/controlsbase.ymlwith env overlay for baseline global parsingresolveBaselineDefault()now handles base+env merge for baselineProblem
Baseline subtraction from #23 only covered per-team diffs. Global config changes from
default.yml/base.ymlstill showed all pending undeployed changes.Test plan
go test ./...)Ref #25