Skip to content

i18n: align search-scope wording (en + zh_CN) - #19

Closed
YRWoods wants to merge 2 commits into
TuYv:masterfrom
YRWoods:i18n/align-search-scope-wording
Closed

i18n: align search-scope wording (en + zh_CN)#19
YRWoods wants to merge 2 commits into
TuYv:masterfrom
YRWoods:i18n/align-search-scope-wording

Conversation

@YRWoods

@YRWoods YRWoods commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Align three incomplete search-scope strings with the rest of the UI (tabs, history, bookmarks, top sites) in both en and zh_CN.

Rationale

  • overlay_searchPlaceholder / popup_searchSources / options_heroDesc already list all four sources
  • cmd_search, notify_installedBody, and popup_searchTabsBookmarks still said only tabs/bookmarks

Changes

Key Change
cmd_search Include history + top sites
notify_installedBody Same scope; \\$ / \\$ placeholders unchanged
popup_searchTabsBookmarks Full source list label

How I tested

  • Same message keys in both locale files
  • Placeholder defs still match for notify_installedBody
  • node --test tests/*.test.js — all pass

Fixes #14

cmd_search, notify_installedBody, and popup_searchTabsBookmarks still
said only tabs/bookmarks while the overlay and options describe history
and top sites too. Align both locales; placeholders unchanged.

Fixes #14

@TuYv TuYv left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for auditing the English and Simplified Chinese search-scope strings. There is one blocking placeholder regression to fix before this can merge:

  • In both locale files, notify_installedBody changes $search$ and $batch$ to \\$. Pounce's formatter only replaces named $name$ tokens, so the installed notification now renders literal \$ instead of the keyboard shortcuts. Please restore the named tokens and add a focused regression test that formats this message with both shortcut substitutions.

Please also keep the diff focused by reverting the unrelated overlay_tabCount formatting-only change, settle on consistent Chinese terminology for history/top sites, and manually verify that the longer popup label fits in both locales.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review:

  1. Restored named $search$ / $batch$ tokens in notify_installedBody (en + zh_CN).
  2. Regression test formats installed body with both shortcuts.
  3. Reverted unrelated overlay_tabCount formatting-only change.
  4. Search-scope wording still expanded (tabs/history/bookmarks/top sites) in both locales.

Please re-review.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Ready for re-review: named $search$ / $batch$ restored + regression test; overlay_tabCount formatting noise removed.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Withdrawing.

@YRWoods YRWoods closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: review English and Simplified Chinese string consistency

2 participants