i18n: align search-scope wording (en + zh_CN) - #19
Closed
YRWoods wants to merge 2 commits into
Closed
Conversation
cmd_search, notify_installedBody, and popup_searchTabsBookmarks still said only tabs/bookmarks while the overlay and options describe history and top sites too. Align both locales; placeholders unchanged. Fixes #14
TuYv
requested changes
Jul 13, 2026
TuYv
left a comment
Owner
There was a problem hiding this comment.
Thanks for auditing the English and Simplified Chinese search-scope strings. There is one blocking placeholder regression to fix before this can merge:
- In both locale files,
notify_installedBodychanges$search$and$batch$to\\$. Pounce's formatter only replaces named$name$tokens, so the installed notification now renders literal\$instead of the keyboard shortcuts. Please restore the named tokens and add a focused regression test that formats this message with both shortcut substitutions.
Please also keep the diff focused by reverting the unrelated overlay_tabCount formatting-only change, settle on consistent Chinese terminology for history/top sites, and manually verify that the longer popup label fits in both locales.
Contributor
Author
|
Addressed review:
Please re-review. |
Contributor
Author
|
Ready for re-review: named |
Contributor
Author
|
Withdrawing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align three incomplete search-scope strings with the rest of the UI (tabs, history, bookmarks, top sites) in both
enandzh_CN.Rationale
overlay_searchPlaceholder/popup_searchSources/options_heroDescalready list all four sourcescmd_search,notify_installedBody, andpopup_searchTabsBookmarksstill said only tabs/bookmarksChanges
cmd_searchnotify_installedBody\\$/\\$placeholders unchangedpopup_searchTabsBookmarksHow I tested
notify_installedBodynode --test tests/*.test.js— all passFixes #14