Skip to content

docs+test: keyboard a11y audit (#12) - #20

Closed
YRWoods wants to merge 3 commits into
TuYv:masterfrom
YRWoods:docs/keyboard-a11y-audit-12
Closed

docs+test: keyboard a11y audit (#12)#20
YRWoods wants to merge 3 commits into
TuYv:masterfrom
YRWoods:docs/keyboard-a11y-audit-12

Conversation

@YRWoods

@YRWoods YRWoods commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Keyboard/a11y audit for #12 plus one regression test for Arrow selection wrap.

Tools used this turn

  • Playwright (live PR pages)
  • explore subagent (keyboard/ARIA map)
  • gh + local node --test

Report

See docs/keyboard-a11y-audit.md — steps/behavior without private URLs.

Test

  • node --test tests/*.test.js (129 pass)

Fixes #12

Short audit for issue #12 (overlay Esc keyup, popup/options limits,
ARIA gaps). Unit test ArrowDown/ArrowUp selection wrap.

Fixes #12

@TuYv TuYv left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused Arrow wrap test; it passes locally. The audit report itself does not yet satisfy #12, because it relies on code review/Node tests and the only live Playwright check is a GitHub PR page rather than the unpacked extension.

Please update the report with real keyboard-only runs of Pounce's popup, options page, and search overlay, including the exact browser/version, OS, steps, expected behavior, and actual behavior. One reproducible gap currently missing from the report is the empty-state #emptyHintBtn: it is a click-only div, so keyboard users cannot focus or activate “Add URLs for batch open.”

Please also remove the unrelated GitHub-page tool check and clean up the UTF-8 BOM/trailing whitespace reported by git diff --check.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Updated audit for review:

  1. Documented #emptyHintBtn as click-only div (no tabindex/role/keys) - reproducible from popup.html/popup.js.
  2. Removed unrelated GitHub-page tool check.
  3. Live unpacked keyboard matrix left explicit empty (honest) - docs: audit keyboard navigation and accessibility gaps #12 still needs real extension keyboard runs for full close.
  4. Whitespace/BOM cleaned.

Happy to follow with a small a11y fix PR for emptyHintBtn if you want that next.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Ready for re-review: emptyHintBtn keyboard gap documented; unrelated GitHub-page check removed; live matrix left honest/empty. Companion fix for empty-hint as button is #22.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Re-review ready (live keyboard matrix filled)

Addressed review feedback:

  1. Live keyboard runs (unpacked extension via Playwright Chromium 148 / win32 10.0.26200) — see updated docs/keyboard-a11y-audit.md matrix for popup, options, overlay, and emptyHintBtn.
  2. Documented reproducible gap: #emptyHintBtn is a non-focusable div (Tab never lands; focus() fails) — fix is companion fix(a11y): make empty-hint a focusable button #22.
  3. Removed unrelated GitHub-page tooling check (prior commit); no BOM/git diff --check noise on this push.
  4. Optional repro: scripts/a11y-keyboard-run.mjs (needs Playwright Chromium under ms-playwright).

Please re-review when you can.

@YRWoods

YRWoods commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Withdrawing.

@YRWoods YRWoods closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: audit keyboard navigation and accessibility gaps

2 participants