Skip to content

i18n: align search source wording (en + zh_CN) - #24

Closed
YRWoods wants to merge 1 commit into
TuYv:masterfrom
YRWoods:feat/i18n-string-consistency
Closed

i18n: align search source wording (en + zh_CN)#24
YRWoods wants to merge 1 commit into
TuYv:masterfrom
YRWoods:feat/i18n-string-consistency

Conversation

@YRWoods

@YRWoods YRWoods commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

i18n consistency for search source wording in English and Simplified Chinese, plus a regression test that locale keys/placeholders stay aligned.

Problem

Fixes #14

Approach

  • Align cmd_search / popup search labels with overlay sources (tabs, bookmarks, history, top sites)
  • zh: 历史 → 历史记录 in popup source list for consistency with overlay
  • Test: same keys + same placeholder names in en and zh_CN

How I tested

  • node --test tests/i18n.test.js tests/preferences.test.js

Same keys and placeholders kept. Search labels now list tabs, bookmarks, history, and top sites consistently. Fixes #14.
@YRWoods

YRWoods commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Withdrawing.

@YRWoods YRWoods closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: review English and Simplified Chinese string consistency

1 participant