fix(a11y): make empty-hint a keyboard-focusable button - #25
Closed
YRWoods wants to merge 1 commit into
Closed
Conversation
Empty state add-URLs control was a non-focusable div. Fixes #12 (keyboard path).
Contributor
Author
|
Withdrawing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the popup empty-state “Add URLs” control a real
buttonso keyboard users can focus and activate it.Problem
Part of #12 —
.empty-hintwas adivwith click-only behavior.Approach
button type=buttonwith existing styles +:focus-visibleclicklistener)How I tested