Conversation
AvhiMaz
left a comment
There was a problem hiding this comment.
overall its fine, just new questions:
hardcoding a single feed id at the program level means we can never change the oracle feed without a full redeploy. can we do something like make it live in MakerConfig so it can be set per market via initialize_market / update_config.
|
please format the code, run |
anything on this @KarthikeyaGundumogula ? |
we can do that but its not necesssary, beacuse we only have one maker and one pool so hardcoding that saves cus |
Right now tests for swap logic will fail we have to create a mock account and pass that account to the swap instruction, and updated mid_price logic, manually serailized data, please check once in the serialization, for reference i kept the
pyth-solana-receiver-sdkin dependencies to check if the price feed correctly serialized or not.