Skip to content

added oracle#11

Merged
AvhiMaz merged 3 commits into
masterfrom
oracle
Mar 18, 2026
Merged

added oracle#11
AvhiMaz merged 3 commits into
masterfrom
oracle

Conversation

@KarthikeyaGundumogula
Copy link
Copy Markdown
Collaborator

Right now tests for swap logic will fail we have to create a mock account and pass that account to the swap instruction, and updated mid_price logic, manually serailized data, please check once in the serialization, for reference i kept the pyth-solana-receiver-sdk in dependencies to check if the price feed correctly serialized or not.

@KarthikeyaGundumogula KarthikeyaGundumogula requested review from AvhiMaz and xydv and removed request for AvhiMaz and xydv March 17, 2026 20:12
Copy link
Copy Markdown
Collaborator

@AvhiMaz AvhiMaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall its fine, just new questions:

hardcoding a single feed id at the program level means we can never change the oracle feed without a full redeploy. can we do something like make it live in MakerConfig so it can be set per market via initialize_market / update_config.

Comment thread src/instructions/execute_swap.rs
Comment thread Cargo.toml
Comment thread src/math.rs
Comment thread src/math.rs Outdated
@AvhiMaz AvhiMaz added ci Trigger CI/CD and removed ci Trigger CI/CD labels Mar 18, 2026
@AvhiMaz
Copy link
Copy Markdown
Collaborator

AvhiMaz commented Mar 18, 2026

please format the code, run make all to make sure we all in a sync and code format

@AvhiMaz AvhiMaz added ci Trigger CI/CD and removed ci Trigger CI/CD labels Mar 18, 2026
@AvhiMaz
Copy link
Copy Markdown
Collaborator

AvhiMaz commented Mar 18, 2026

hardcoding a single feed id at the program level means we can never change the oracle feed without a full redeploy. can we do something like make it live in MakerConfig so it can be set per market via initialize_market / update_config

anything on this @KarthikeyaGundumogula ?

@KarthikeyaGundumogula
Copy link
Copy Markdown
Collaborator Author

KarthikeyaGundumogula commented Mar 18, 2026

hardcoding a single feed id at the program level means we can never change the oracle feed without a full redeploy. can we do something like make it live in MakerConfig so it can be set per market via initialize_market / update_config

anything on this @KarthikeyaGundumogula ?

we can do that but its not necesssary, beacuse we only have one maker and one pool so hardcoding that saves cus

@AvhiMaz AvhiMaz merged commit 52d5bd0 into master Mar 18, 2026
4 checks passed
@AvhiMaz AvhiMaz deleted the oracle branch March 18, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants