add tests for init market, update config, deposit and withdraw#9
Merged
Conversation
AvhiMaz
requested changes
Mar 16, 2026
Collaborator
AvhiMaz
left a comment
AvhiMaz
left a comment
There was a problem hiding this comment.
nits:
- can you also add the tests for
withdrawinstruction? - also few changes required
- can you also add negative tests? like non-admin can't call
update_configordeposit
also the ci fails because of workflow, pushed some changes here a403e24
need to rebase it again.
AvhiMaz
changed the title
Collaborator
Author
|
will add the withdraw, negative test cases and the changes. |
AvhiMaz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
this mr adds tests for all the available instructions.