Slight jsexecute.js improvements #323
Open
+18
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It helps if you can show at least some micro benchmark where these are faster |
Author
|
listIndex() test done with no warp timer, tested 100,000 times each for 'any', 'last', and normal numbers: numbers-old.txt numbers-new.txt Do you also want listContains() tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made super small improvements to
listIndex(), andlistIndexSlow().listIndex()no longer expects a string index first because numbers are more usually passed than 'last', or anything similar.listIndexSlow()is more concise.Also, checking with
indexOf()first inlistContains()is faster than only usingcompareEqual(). I was clearly on something last night..