Conversation
|
bumped version, also did some minor improvements to quality |
|
Yes #29 was fixed, I forgot to link it in my PR. |
|
Thanks @float3 ! I should have some time to review this over the weekend |
|
I still wanted to see if I can expose extern "C" {
pub fn oidnExecuteSYCLFilterAsync(
filter: OIDNFilter,
depEvents: *const sycl_event,
numDepEvents: ::std::os::raw::c_int,
doneEvent: *mut sycl_event,
);
}correctly |
Twinklebear
left a comment
There was a problem hiding this comment.
This looks good! For oidnExecuteSYCLFilterAsync, it'd be interesting to think about wrapping it with some async/await semantics, I haven't been following Rust as closely but it sounded like there isn't async/await in the standard library? On another repo of mine someone added async support w/ feature flags to select between 2 popular libraries providing that functionality: Twinklebear/tobj#69
|
Rust’s async/await is stable, but have to choose an executor, (for example Tokio or async-std) |
|
either way I want to save that for a future PR |
|
I think there are a few other places that async exists in oidn, so maybe a issue for it is useful. |
|
yeah let's make a issue |
…d of workspace members
|
tested with my pathtracer, everything seems to work fine |
|
happy new rust edition day 🎉 |
Twinklebear
left a comment
There was a problem hiding this comment.
Separate issue for async sounds great, thanks for working on this pr @float3 !
No description provided.