Remove Node.js import from common code #97
Closed
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the fix and sorry for my delay, since I was too busy for Typir. |
Member
|
Totally overlooked that there was already a PR for this, sorry @aabounegm didn't mean to step on your toes there, hope that solution in #98 works as well. |
Contributor
Author
|
@montymxb No worries, the important thing is that it is fixed, and your solution is better anyway :) I'll close this PR now since the other is merged already. I hope a patch version can be released soon so I can fix my project's playground |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 imports of
node:utils/typesthat caused the core typir package code to not be compatible with non-Node.js environments (specifically, web). This causes an issue when trying to build web playground for a Langium project (for example, my project stella).I replaced those utilities with their native JavaScript equivalent.
Fixes #96