Skip to content

Aa/ghc810 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
augyg wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Aa/ghc810 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ea020
Remove Duplicated Instance
augyg Jul 30, 2024
6a088de
Merge remote-tracking branch 'origin/aa/ghc810' into aa/ghc810
augyg Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions common/Rhyolite/Vessel/AuthenticatedV.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ import Data.Vessel.ViewMorphism (ViewQueryResult, ViewMorphism(..), ViewHalfMorp
import Data.Vessel.Vessel (vessel)
import Data.Bifoldable

-- TODO upstream this instance
-- see https://github.com/obsidiansystems/vessel/pull/22/commits/b61428df85f0befa90a8cbd18cb860ebded70e21
instance (Has' Semigroup k (FlipAp g), GCompare k, Has View k) => DecidablyEmpty (Vessel k g) where
isEmpty = nullV
-- -- TODO upstream this instance
-- -- see https://github.com/obsidiansystems/vessel/pull/22/commits/b61428df85f0befa90a8cbd18cb860ebded70e21
-- instance (Has' Semigroup k (FlipAp g), GCompare k, Has View k) => DecidablyEmpty (Vessel k g) where
-- isEmpty = nullV

-- | An internal key type used to glue together parts of a view selector
-- that have different authentication contexts.
Expand Down