Added Kalman Filter + Minor Motion Control Changes#3420
Open
mkhlb wants to merge 86 commits intoUBC-Thunderbots:motor_firmware_integrationfrom
Open
Added Kalman Filter + Minor Motion Control Changes#3420mkhlb wants to merge 86 commits intoUBC-Thunderbots:motor_firmware_integrationfrom
mkhlb wants to merge 86 commits intoUBC-Thunderbots:motor_firmware_integrationfrom
Conversation
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
Comment on lines
20
to
23
| map<uint32, Angle> robot_orientations = 5; | ||
|
|
||
| uint64 sequence_number = 4; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| map<uint32, Angle> robot_orientations = 5; | |
| uint64 sequence_number = 4; | |
| } | |
| uint64 sequence_number = 4; | |
| map<uint32, Angle> robot_orientations = 5; | |
| } |
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
itsarune
reviewed
Jan 13, 2025
…o high-level-mp
…o high-level-mp
…o high-level-mp
…o high-level-mp
…o high-level-mp
…o high-level-mp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Many changes were done.
Implemented a kalman filter for thunderloop that composes IMU data to track robot position more accurately.
Now when following trajectories, additionally to trajectories current target velocity, add a proportional component based on error from predicted position.
Testing Done
Moved robot.
Tested IMU variance, got about 0.0019 deg variance, expected about 0.0016 deg.
Need to do much further testing with new robots.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue